LinkGenerator: set repo to empty if invalid #2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgaiacs
reviewed
Sep 29, 2025
Contributor
There was a problem hiding this comment.
Sorry my ignorance here. Is preset required only for the test? If it is required for the test, I think it should be included in js/packages/binderhub-react-components/package.json?
Member
Author
There was a problem hiding this comment.
You're right, I've added it
rgaiacs
approved these changes
Sep 30, 2025
Contributor
rgaiacs
left a comment
rgaiacs
left a comment
There was a problem hiding this comment.
Looks good to me.
After this is merged, we should made a minor release of binderhub-react-components. This need to be manual at the moment.
Member
|
@manics, should we go for a merge here, or do you want additional review? |
consideRatio
pushed a commit
to jupyterhub/helm-chart
that referenced
this pull request
Nov 5, 2025
jupyterhub/binderhub#2020 Merge pull request #2020 from manics/clear-invalid-repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3d29702 fixes #2019
The other commits are for CI testing